Skip to content

Conversation

@oruebel
Copy link
Contributor

@oruebel oruebel commented Nov 19, 2024

Add GitHub action to run a link checker on the source files

This action does not build the website but checks links only in the source files directly. If we want to check all links, we should also add action to deploy the PRs to a temporary place so that we can run the linkchecker on that.

@oruebel oruebel marked this pull request as ready for review November 19, 2024 23:42
@oruebel oruebel requested a review from bendichter November 19, 2024 23:42
@rly
Copy link
Contributor

rly commented Nov 23, 2024

The only failing link check is the INCF URL most likely due to an issue with SSL certificates. INCF URLs also fail the Sphinx linkcheck on the nwb-overview site. We ignored the INCF URL there. We could do the same here, or we could run Lychee with --insecure. Either is fine with me.

@oruebel
Copy link
Contributor Author

oruebel commented Nov 23, 2024

Running with --insecure seems reasonable

@oruebel oruebel merged commit a972875 into dev Nov 23, 2024
1 check passed
@oruebel oruebel deleted the add/link_check_action branch November 23, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants